This repository has been archived by the owner on Mar 9, 2018. It is now read-only.
Replace Hash#to_json and ActiveSupport::JSON to MultiJson #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ileitch
added a commit
that referenced
this pull request
Jun 20, 2012
Replace Hash#to_json and ActiveSupport::JSON to MultiJson
|
Thank you. |
|
This is failing on REE: http://travis-ci.org/#!/ileitch/rapns/jobs/1666415 Any idea why? |
|
Because of ok_json, MultiJson's default JSON engine, converting ActiveSupport::OrderedHash into Hash in internal. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to select more fast and more space-saving JSON engine.
Space-saving is important for non-ascii utf8 string.
See the following examples.
ActiveSupport::JSON.encode( { "aps" => { "alert" => "あいうえお" } } ) #=> {"aps":{"alert":"\u3042\u3044\u3046\u3048\u304a"}} # 50 bytes
MultiJson.dump( { "aps" => { "alert" => "あいうえお" } ) #=> {"aps":{"alert":"あいうえお"}} # 35 bytes